Fix: Ensure cross-platform compatibility for sed command in CI script #5316
+5
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In the CI script, the following command can cause issues on macOS:
sed -i '/,0/d' lcov.info
The
sed -i
flag directly edits a file in place, but its behavior differs across platforms:-i
option requires an argument for the extension of a backup file (even if it’s empty). Without this, the script fails.Proposed Fix
To ensure compatibility across both Linux and macOS, we updated the script to detect the operating system and adjust the
sed
command accordingly.Changes Made
$OSTYPE
.sed
command to usesed -i ''
on macOS andsed -i
on Linux.Updated Code
Importance of Fix
npx changeset add
)